Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/2816 token detection mvp #2901

Merged
merged 57 commits into from
Sep 17, 2021
Merged

Feature/2816 token detection mvp #2901

merged 57 commits into from
Sep 17, 2021

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Jul 14, 2021 •
edited
Loading

Description

  • Replace contract metadata (static JSON token list) with new TokenListController dynamic list
  • Upgrade a few libraries such as Redux + lock versions to guarantee versions even without yarn.lock
  • Add warning to the top of custom token page
  • Update copy + layout for footer on Wallet page (Home page). Also removed Buy ETH button on wallet footer.
  • Add token detection toggle on Security & Privacy page (hooked up to PreferencesController)
  • A little bit of refactor (Convert JSX to TSX)

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue
#2816

Next Steps

  • Needs translation

Cal-L added 13 commits June 30, 2021 14:41
@Cal-L
Update AssetDetectionController to use TokenDetectionController
85fd056
@Cal-L
Update redux with token list controller data
4a1492e
@Cal-L
Replace contract map with token list from TokenListController. Add ty…
d0ce6e4 
…pescript support
@Cal-L
- Update to use iconUrl from token list
c1e7a14 
- Create token list selectors
- Minor refactor into typescript
- Update copies
@Cal-L
Hook up preferences controller to handle static token list
67534ca
@Cal-L
Use controllers v12.1.0. Set up last bit for token list controller co…
0ac2911 
…nstructor
@Cal-L
Remove controllers tgz
f566033
@Cal-L
Add comments to token reducers
8dd3312
@Cal-L
Merge in develop
1d01603
@Cal-L
Remove all contract metadata imports
82a22c8
@Cal-L
Upgrade nodeify library to fix pbkdf2 library crasher
b6cf383
@Cal-L
Remove comment and lock library version
48d7a79
@Cal-L
Remove unused field on engine reducer
40d0cf7
@Cal-L Cal-L requested a review from a team as a code owner July 14, 2021 19:21
@Cal-L Cal-L added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) design-review Any feature that needs feedback from the design team and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jul 14, 2021
@Cal-L Cal-L self-assigned this Jul 14, 2021
@Cal-L Cal-L added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Jul 14, 2021
sethkfman
sethkfman reviewed Jul 14, 2021
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments and small updates. Let me know if you have questions

app/components/UI/Tokens/index.js Outdated Show resolved Hide resolved
app/components/UI/Tokens/index.js Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
app/util/tokens.ts Outdated Show resolved Hide resolved
Cal-L
Cal-L commented Jul 15, 2021
View reviewed changes
Copy link
Contributor Author

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sethkfman Added test

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@cortisiko cortisiko assigned cortisiko and unassigned Cal-L Sep 8, 2021
@cortisiko cortisiko added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Sep 8, 2021
cortisiko
cortisiko approved these changes Sep 15, 2021
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀 🚀 🚀

@cortisiko cortisiko assigned Cal-L and unassigned cortisiko Sep 15, 2021
@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Sep 15, 2021
@mobularay mobularay removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 16, 2021
@Cal-L Cal-L mentioned this pull request Sep 16, 2021
Closed
5 tasks
@Cal-L Cal-L merged commit 7f695c4 into develop Sep 17, 2021
@Cal-L Cal-L deleted the feature/2816-token-detection-mvp branch September 17, 2021 23:14
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@Cal-L @adonesky1
Feature/2816 token detection mvp (#2901)
5228a68 
* Update AssetDetectionController to use TokenDetectionController

* Update redux with token list controller data

* Replace contract map with token list from TokenListController. Add typescript support

* - Update to use iconUrl from token list
- Create token list selectors
- Minor refactor into typescript
- Update copies

* Hook up preferences controller to handle static token list

* Use controllers v12.1.0. Set up last bit for token list controller constructor

* Remove controllers tgz

* Add comments to token reducers

* Remove all contract metadata imports

* Upgrade nodeify library to fix pbkdf2 library crasher

* Remove comment and lock library version

* Remove unused field on engine reducer

* Add missing blue100

* Change Alert to use enums. Add jest types. Remove comments. Write test for token util.

* Handle undefined passed to token util

* Update enzyme to support jest diving redux connected components

* Fix all unit tests that uses Redux. Update snapshots.

* Update app to support latest controllers.

* Provide TokensController with provider on initialization.

* Clean up code to display asset logos

* Create static asset generation script. Generate on build + watch.

* Update static logos

* Properly format static logos file

* Update controller package

* Mock static-logos.js for testing

* ignored tokens updates

* add migration

* cleanup

* Upgrade controller version

* Use latest controller version that includes abort controller polyfill

* Use TokenListController types

* Remove unused EthInput

* Remove commented code in QuotesView.js

* No need to set address on tokenlist array

* Update controller version

* Remove TransactionDirection unused file. ESLint ignore static assets file

* Refactor wallet to tsx

* Add missing deps array

* Add missing tab label

* Don't lint generated static logos file. Fix crasher for ipfs logos.

* Fix unit test

* Update title and cta label on tokens and nft pages

* Fix unit test

* Fix unit test

* Rename asset list extension

* Showing icons for payment request flow

* Fix showing icon in payments. Fix tests

Co-authored-by: Alex <adonesky@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gantunesr gantunesr gantunesr left review comments

@sethkfman sethkfman sethkfman left review comments

@cortisiko cortisiko cortisiko approved these changes

Assignees

@Cal-L Cal-L

Labels
QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Cal-L @sethkfman @cortisiko @gantunesr @mobularay @adonesky1