Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix login bug #3464

Closed
Cal-L opened this issue Dec 1, 2021 · 0 comments
Closed

Fix login bug #3464

Cal-L opened this issue Dec 1, 2021 · 0 comments
Assignees
@Cal-L
Labels
type-bug Something isn't working

Comments

@Cal-L
Copy link
Contributor

Cal-L commented Dec 1, 2021 •
edited
Loading

Description

Login screen always shows even if user is logged in
To reproduce: Log in to app. Kill app. Reopen app. Notice log in screen is shown before it auto navigates to wallet

Technical Details

  • Identify where issue lives
  • Follow React Navigation docs around replacing switch navigator

Acceptance Criteria

  • Log in screen should not show in the provided scenario in the description above (if remember me or biometrics was enabled)
  • Log out should navigate back to log in screen
  • Log in screen should respect biometrics & remember me settings from the settings page
  • Should not be able to hit the Android back button on the log in screen
  • Extra: Log in regression tests

References
@Cal-L Cal-L added the type-bug Something isn't working label Dec 1, 2021
@Cal-L Cal-L mentioned this issue Dec 1, 2021
Merged
3 tasks
@Cal-L Cal-L self-assigned this Dec 1, 2021
This was referenced Dec 2, 2021
Merged
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cal-L Cal-L

Labels
type-bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Cal-L @mobularay