Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/3464 fix login bug #3484

Merged
merged 13 commits into from
Dec 8, 2021
Merged

Bug/3464 fix login bug #3484

merged 13 commits into from
Dec 8, 2021

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Dec 7, 2021

Description

#3464

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

@Cal-L Cal-L added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Dec 7, 2021
@Cal-L Cal-L requested a review from a team as a code owner December 7, 2021 22:11
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2021

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

gantunesr
gantunesr approved these changes Dec 8, 2021
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just left some questions and a suggestion.

app/components/Views/Login/index.js Outdated Show resolved Hide resolved
app/actions/user/index.js Show resolved Hide resolved
app/components/Views/Login/index.js Show resolved Hide resolved
@cortisiko cortisiko added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Dec 8, 2021
cortisiko
cortisiko approved these changes Dec 8, 2021
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮 🌮 🌮

@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Dec 8, 2021
@Cal-L Cal-L merged commit c2a294a into develop Dec 8, 2021
@Cal-L Cal-L deleted the bug/3464-fix-login-bug branch December 8, 2021 21:44
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman left review comments

@cortisiko cortisiko cortisiko approved these changes

@gantunesr gantunesr gantunesr approved these changes

Assignees
No one assigned
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Cal-L @sethkfman @cortisiko @gantunesr