Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that network exists when adding a custom network #3800

Closed
blackdevelopa opened this issue Feb 23, 2022 · 3 comments · Fixed by #3802
Closed

Check that network exists when adding a custom network #3800

blackdevelopa opened this issue Feb 23, 2022 · 3 comments · Fixed by #3802
Assignees
@blackdevelopa
Labels
Code Impact - Medium Average task code change that can relatively safely being applied to the codebase

Comments

@blackdevelopa
Copy link
Contributor

blackdevelopa commented Feb 23, 2022 •
edited by sethkfman
Loading

Description

Before adding a custom network, check that this network isn't already added

Acceptance Criteria

  • (Stretch UX Improvement-Create ticket if not completed in this ticket) If network already added and the user attempts to add custom network again check and prompt the user that it is already added (check against RPC url)

#3545
@blackdevelopa blackdevelopa self-assigned this Feb 23, 2022
@blackdevelopa blackdevelopa changed the title Check that network exist when adding a custom network Check that network exists when adding a custom network Feb 23, 2022
@blackdevelopa blackdevelopa mentioned this issue Feb 23, 2022
Merged
3 tasks
@blackdevelopa blackdevelopa added the Code Impact - Medium Average task code change that can relatively safely being applied to the codebase label Feb 23, 2022
@sethkfman
Copy link
Contributor

Hey team! Please add your planning poker estimate with ZenHub @blackdevelopa @cortisiko

@geomad
Copy link

geomad commented Mar 2, 2022

Hey! This feature would prevent users running nodes locally to add them as RPC (for example ethereum network), also unable to add an alternative network if the RPC provided by brave is down. I'm already getting the error "This network is already added." when trying to do so.

@sethkfman
Copy link
Contributor

@geomad This ticket was updated to check against the same RPC url instead of the chain ID.

@blackdevelopa blackdevelopa mentioned this issue Nov 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blackdevelopa blackdevelopa

Labels
Code Impact - Medium Average task code change that can relatively safely being applied to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check that network exists when adding a custom network MetaMask/metamask-mobile
3 participants
@geomad @sethkfman @blackdevelopa