Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that network exists when adding a custom network #3802

Merged
merged 5 commits into from
Mar 7, 2022
Merged

Check that network exists when adding a custom network #3802

merged 5 commits into from
Mar 7, 2022

Conversation

blackdevelopa
Copy link
Contributor

@blackdevelopa blackdevelopa commented Feb 23, 2022 •
edited
Loading

Description
Before adding a custom network, check that this network isn't already added (check against chain ID)

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #3800

@blackdevelopa blackdevelopa requested a review from a team as a code owner February 23, 2022 06:43
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@blackdevelopa blackdevelopa self-assigned this Feb 23, 2022
@blackdevelopa blackdevelopa added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 23, 2022
sethkfman
sethkfman reviewed Feb 24, 2022
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know when you update the uniqueness check.

@blackdevelopa blackdevelopa force-pushed the feature/3800-check-custom-network branch from 00f117f to 26c256b Compare March 3, 2022 13:59
sethkfman
sethkfman reviewed Mar 3, 2022
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy change required

@blackdevelopa blackdevelopa added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Mar 4, 2022
@cortisiko cortisiko added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Mar 4, 2022
sethkfman
sethkfman approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 7, 2022
@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Mar 7, 2022
cortisiko
cortisiko approved these changes Mar 7, 2022
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮 🌮

@cortisiko cortisiko merged commit ee82077 into main Mar 7, 2022
@cortisiko cortisiko deleted the feature/3800-check-custom-network branch March 7, 2022 20:03
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rekmarks rekmarks rekmarks left review comments

@cortisiko cortisiko cortisiko approved these changes

@sethkfman sethkfman sethkfman approved these changes

Assignees

@blackdevelopa blackdevelopa

Labels
QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check that network exists when adding a custom network
4 participants
@blackdevelopa @sethkfman @cortisiko @rekmarks