Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

As a new user I should not be able to enable Remember me (hide remember me) #4194

Closed
owencraston opened this issue May 2, 2022 · 1 comment
Closed

As a new user I should not be able to enable Remember me (hide remember me) #4194

owencraston opened this issue May 2, 2022 · 1 comment
Assignees
@plasmacorral
Labels
needs-qa Any New Features that needs a full manual QA prior to being added to a release. team-accounts type-security

Comments

@owencraston
Copy link
Contributor

owencraston commented May 2, 2022 •
edited
Loading

Description

A new install of the app should not be able to enable remember me.

  • In order to help the the total deprecation of this feature, we want to stop new users from activating this feature as it will just make the deprecation harder.

Technical Details

  • New installs should not be able to enable Remember me
  • This essentially means we are going to remove the front end that hooks up this feature but the "backend" will still exist
  • We don't want to lock out users who have enabled this feature already so this feature must only effect people setting up a wallet
  • Since @sethkfman has made many important changes to the authentication flow we must work off of what he has done in that PR

Acceptance Criteria

Scenario 1:

  • GIVEN A new user installs MM mobile
  • WHEN The user goes to setup their wallet
  • THEN they will not see the remember me option!
  • AND the wallet creation works as normal

Scenario 2:

  • GIVEN An existing user who was using remember me updates the app
  • WHEN The user opens the app
  • THEN they should still be logged in

Scenario 3:

  • GIVEN An existing user who was using remember me updates the app
  • WHEN The the vault recovery fails and the user gets logged out
  • THEN remember me is no longer an option for the user
  • AND they will need to use their SRP to recover the wallet

References
@owencraston owencraston mentioned this issue May 16, 2022
Merged
3 tasks
@AlexJupiter AlexJupiter added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label May 19, 2022
@owencraston owencraston mentioned this issue Aug 2, 2022
Merged
3 tasks
@plasmacorral
Copy link
Contributor

merged in PR4305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plasmacorral plasmacorral

Labels
needs-qa Any New Features that needs a full manual QA prior to being added to a release. team-accounts type-security
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AlexJupiter @owencraston @plasmacorral