-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide Remember me strings #4784
Hide Remember me strings #4784
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
56d480e
to
019e50f
Compare
019e50f
to
7c3c294
Compare
Editing my original comment. Looks good, but can we modify the content slightly? otherwise all good on this from a content perspective. title: Enter your password to turn off Remember me As for the turning Remember me on strings, can we strike the quotation marks and modify the content: Title: Turn on Remember me |
9035b78
to
9c45b8e
Compare
This PR does not affect the code of next release |
Description
1. What is the reason for the change?
2. What is the improvement/solution?
The strings were agreed upon here
Screenshots/Recordings
these are the modal designs, we have no designs for the settings toggle
Issue
Progresses #4194
Checklist