Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix no password logged out scenario #1028

Merged
merged 6 commits into from
Aug 27, 2019
Merged

Conversation

brunobar79
Copy link
Contributor

Fixes #1026

After the fix: https://recordit.co/44kNpzIuNc

@brunobar79 brunobar79 added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Aug 27, 2019
Copy link
Contributor

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on both iOS and Android, QA Passed 👍

@brunobar79 brunobar79 merged commit fa7e2ed into develop Aug 27, 2019
@brunobar79 brunobar79 deleted the fix-no-password-logged-out branch August 27, 2019 22:54
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
* fix no password logged out scenario

* fix unit tests

* update lockscreen and snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-qa Any New Features that needs a full manual QA prior to being added to a release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If no password is set, user should not see log in screen
3 participants