Detox: Browser Tests #1147
Merged
Detox: Browser Tests #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibrahimtaveras00
requested review from
estebanmino and
brunobar79
and removed request for
brunobar79
brunobar79
approved these changes
Oct 21, 2019
| @@ -264,7 +264,7 @@ class AccountApproval extends PureComponent { | |||
| <Text style={styles.headerTitle} testID={'dapp-name-title'} numberOfLines={1}> | |||
| {title} | |||
| </Text> | |||
| <Text style={styles.headerUrl} numberOfLines={1}> | |||
| <Text style={styles.headerUrl} testID={'dapp-name-url'} numberOfLines={1}> | |||
There was a problem hiding this comment.
Break down props in different lines
| @@ -128,7 +128,7 @@ export default class BrowserBottomBar extends PureComponent { | |||
| <TouchableOpacity onPress={showTabs} style={styles.iconButton} testID={'show-tabs-button'}> | |||
| <TabCountIcon style={styles.tabIcon} /> | |||
| </TouchableOpacity> | |||
| <TouchableOpacity onPress={goHome} style={styles.iconButton}> | |||
| <TouchableOpacity onPress={goHome} style={styles.iconButton} testID={'home-button'}> | |||
There was a problem hiding this comment.
Break down props in different lines
e2e/browser-tests.spec.js
Outdated
| 'use strict'; | ||
| import TestHelpers from './helpers'; | ||
|
|
||
| const EthereumEnable = 'https://brunobar79.github.io/dapp-issues-repro/'; |
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* added tests for browser and dapps * rename files to be picked up by e2e tests * updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tests the following:
Seen here = http://recordit.co/z9mlQdH7ug