Detox: beef up onboarding and tutorial tests #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibrahimtaveras00
requested review from
brunobar79 and
estebanmino
and removed request for
brunobar79
brunobar79
approved these changes
Oct 21, 2019
| @@ -72,7 +72,9 @@ class Step2 extends PureComponent { | |||
| */ | |||
| content = () => ( | |||
| <View style={onboardingStyles.contentContainer}> | |||
| <Text style={onboardingStyles.content}>{strings('onboarding_wizard.step2.content1')}</Text> | |||
| <Text style={onboardingStyles.content} testID={'step2-title'}> | |||
There was a problem hiding this comment.
when u have 2+ props on the same element, break it down in different lines
| @@ -121,7 +121,9 @@ class Step3 extends PureComponent { | |||
| */ | |||
| content = () => ( | |||
| <View style={onboardingStyles.contentContainer}> | |||
| <Text style={onboardingStyles.content}>{strings('onboarding_wizard.step3.content1')}</Text> | |||
| <Text style={onboardingStyles.content} testID={'step3-title'}> | |||
| @@ -136,7 +138,7 @@ class Step3 extends PureComponent { | |||
| if (!coachmarkTopReady || !viewTopReady) return null; | |||
| return ( | |||
| <View style={[styles.main, { top: this.state.viewTop }]}> | |||
| <View style={styles.accountLabelContainer}> | |||
| <View style={styles.accountLabelContainer} testID={'account-label'}> | |||
| @@ -87,7 +87,7 @@ class Step4 extends PureComponent { | |||
| */ | |||
| content = () => ( | |||
| <View style={onboardingStyles.contentContainer}> | |||
| <Text style={onboardingStyles.content}> | |||
| <Text style={onboardingStyles.content} testID={'step4-title'}> | |||
| @@ -95,7 +95,9 @@ class Step5 extends PureComponent { | |||
| */ | |||
| content = () => ( | |||
| <View style={onboardingStyles.contentContainer}> | |||
| <Text style={onboardingStyles.content}>{strings('onboarding_wizard.step5.content1')}</Text> | |||
| <Text style={onboardingStyles.content} testID={'step5-title'}> | |||
| @@ -78,7 +78,9 @@ class Step6 extends PureComponent { | |||
| */ | |||
| content = () => ( | |||
| <View style={onboardingStyles.contentContainer}> | |||
| <Text style={onboardingStyles.content}>{strings('onboarding_wizard.step6.content')}</Text> | |||
| <Text style={onboardingStyles.content} testID={'step6-title'}> | |||
| @@ -171,7 +171,9 @@ class Onboarding extends PureComponent { | |||
| <ScrollView style={baseStyles.flexGrow} contentContainerStyle={styles.scroll}> | |||
| <View style={styles.wrapper}> | |||
| <View style={styles.ctas}> | |||
| <Text style={styles.title}>{strings('onboarding.title')}</Text> | |||
| <Text style={styles.title} testID={'onboarding-screen-title'}> | |||
| @@ -140,40 +140,49 @@ export default class OnboardingCarousel extends PureComponent { | |||
| > | |||
| <View key={'1'} style={baseStyles.flexGrow}> | |||
| <View style={styles.tab}> | |||
| <Text style={styles.title}>{strings('onboarding_carousel.title1')}</Text> | |||
| <Text style={styles.title} testID={'carousel-screen-one'}> | |||
| /> | ||
| </View> | ||
| </View> | ||
| <View key={'2'} style={baseStyles.flexGrow}> | ||
| <View style={styles.tab}> | ||
| <Text style={styles.title}>{strings('onboarding_carousel.title2')}</Text> | ||
| <Text style={styles.title} testID={'carousel-screen-two'}> |
| /> | ||
| </View> | ||
| </View> | ||
| <View key={'3'} style={baseStyles.flexGrow}> | ||
| <View style={styles.tab}> | ||
| <Text style={styles.title}>{strings('onboarding_carousel.title3')}</Text> | ||
| <Text style={styles.title} testID={'carousel-screen-three'}> |
brunobar79
force-pushed
the
update-onboarding-wizard-tests
branch
from
a2a4ae0
to
e73cd8b
Compare
…date-onboarding-wizard-tests
|
Ignore my comments, our prettier config likes that 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds assertions while going through onboarding carousel as well as the tutorial wizard