Feature: speed up transaction #1176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunobar79
approved these changes
Nov 1, 2019
| return this.renderEmpty(); | ||
| } | ||
|
|
||
| const { submittedTransactions, confirmedTransactions } = this.props; |
There was a problem hiding this comment.
const { submittedTransactions, confirmedTransactions, transactions, header } = this.props;
| @@ -129,6 +138,110 @@ class TransactionsNotificationManager { | |||
| } | |||
| } | |||
|
|
|||
| _handleTransactionsWatchTableUpdate = transactionMeta => { | |||
There was a problem hiding this comment.
Can we rename this to list instead of table?
locales/es.json
Outdated
| "cancel_tx_title": "¿Intentar cancelar?", | ||
| "cancel_tx_message": "Enviar este intento no garantiza que su transacción original será cancelada. Si el intento de cancelación es exitoso, se le cobrará la tarifa de transacción anterior.", | ||
| "speed_up_tx_title": "¿Intentar acelerar?", | ||
| "speed_up_tx_message": "nviar este intento no garantiza que su transacción original se acelerará. Si el intento de acelerar es exitoso, se le cobrará la tarifa de transacción anterior.", |
locales/es.json
Outdated
| "cancel_tx_message": "Enviar este intento no garantiza que su transacción original será cancelada. Si el intento de cancelación es exitoso, se le cobrará la tarifa de transacción anterior.", | ||
| "speed_up_tx_title": "¿Intentar acelerar?", | ||
| "speed_up_tx_message": "nviar este intento no garantiza que su transacción original se acelerará. Si el intento de acelerar es exitoso, se le cobrará la tarifa de transacción anterior.", | ||
| "nevermind": "No importa", |
locales/es.json
Outdated
| "speed_up_tx_message": "nviar este intento no garantiza que su transacción original se acelerará. Si el intento de acelerar es exitoso, se le cobrará la tarifa de transacción anterior.", | ||
| "nevermind": "No importa", | ||
| "gas_cancel_fee": "Tarifa de Cancelación", | ||
| "gas_speed_up_fee": "Tarifa de Aceleración " |
|
Issue 1: Speed up notification Issue 2: Went to kyberswap.com to transfer some DAI and when I attempted to speed up the txn, tapping on the CTA didn't do anything and there was a warning; seen here = https://recordit.co/yJkggYty9x
Issue 3: Went to uniswap trying to get some DAI, and I went to edit my gas to be slow, upon going back to the confirm screen and tapping on the confirm button, I get this; seen here = https://recordit.co/qoY7XwGEnK
|
ibrahimtaveras00
added
the
needs-qa
ibrahimtaveras00
approved these changes
Nov 8, 2019
estebanmino
changed the title
…tamask-mobile into feature/speed-up-transaction
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* render and speed up * parse nonce * wip handle transactions * handle speed up * handle one tx per nonce * perf * filter once * handle notifications * locale * locale es * not timeout * more locale * handle listeners * snaps * handle tx view * status * fix callbacks issue * ignore * missing locale * speed_up * _handleTransactionsWatchListUpdate * locales * props * speedup * locale * keyextractor * fix instapay * fix filter * fix filter for real * fix filter for real for real * move everything one level up on dep tree * snaps * bump gaba * fix imports to new gaba * more import changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds ability to speed up transactions
Checklist
Issue
Resolves #1107