Bugfix: cancel and speedup insufficient funds #1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estebanmino
added
the
needs-qa
brunobar79
approved these changes
Dec 17, 2019
| const { accounts } = this.props; | ||
| const checksummedFrom = safeToChecksumAddress(tx.transaction.from); | ||
| const balance = accounts[checksummedFrom].balance; | ||
| return hexToBN(balance).lt( |
There was a problem hiding this comment.
You might want to wrap this in a try & catch and return true(?) on the catch.
The reason is that there are several values involved (gas, tx value, rate, gas price) and those come from different sources, if one of those requests fail, the whole thing will fail too, and I'd prefer in that case to fail later rather than prohibiting everyone
|
The disabled cta works good 👍 However, when I sanity checked speeding up txn's when I have plenty of funds, I get a possible unhandled promise rejection seen here = http://recordit.co/e1x3fXNeTI
|
|
fixed #1252 (comment) . on gaba |
ibrahimtaveras00
approved these changes
Jan 6, 2020
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* alert message * snaps * fix * bump gaba * try catch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of showing an alert I blocked the button to do a cancel / speed up as you can see here
https://recordit.co/uPCGfIzRqW
Once address book pr we can use the same error component here
Checklist
Issue
Resolves #1208