Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix iframe injection #1282

Merged
merged 3 commits into from
Jan 16, 2020
Merged

Fix iframe injection #1282

merged 3 commits into from
Jan 16, 2020

Conversation

brunobar79
Copy link
Contributor

@brunobar79 brunobar79 commented Jan 16, 2020 •
edited
Loading

This should fix the broken e2e test

ibrahimtaveras00
ibrahimtaveras00 approved these changes Jan 16, 2020
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on both OS's, QA Passed 👍

@brunobar79 brunobar79 merged commit d30cadc into develop Jan 16, 2020
@brunobar79 brunobar79 deleted the fix-iframe-injection branch January 16, 2020 22:41
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
Fix iframe injection (#1282)
3173518 
* fix iframe injection

* refactor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brunobar79 @ibrahimtaveras00