Bugfix: new send flow amount balance #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estebanmino
added
the
needs-qa
|
Issue 1: In the case of attempting to send a collectible, when I get to the Send > Amount view the "Next" CTA is disabled and I cannot proceed. Shows the below warning
|
|
@ibrahimtaveras00 you have a video of this? i can't repro |
ibrahimtaveras00
approved these changes
Jan 24, 2020
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* add balance * snaps * ui issue * fix collectible
jpcloureiro
added a commit
that referenced
this pull request
Jul 2, 2024
## **Description** Moving away from `.patch` changes on the webview Our [RNWebView fork](https://github.com/MetaMask/react-native-webview-mm) contains the security patches. The "Javascript Injection" patch was removed and the related patches to fix bugs introduced by that. Jest snapshots updates to reflect the new RNWebView component ## **Related issues** [mobile-planning #1294](https://github.com/MetaMask/mobile-planning/issues/1294) ## Acceptance Criteria - [x] https://github.com/MetaMask/mobile-planning/issues/1618 ~must be closed with zero bugs~ Done ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: tommasini <46944231+tommasini@users.noreply.github.com> Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com> Co-authored-by: Curtis David <Curtis.David7@gmail.com> Co-authored-by: legobt <6wbvkn0j@anonaddy.me> Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com> Co-authored-by: jiexi <jiexiluan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding balance section missing in new send flow pr
Checklist
Issue
Resolves #???