fix: Make confirmations exclusively use approval origin #12980
+10
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OGPoyraz
added
the
No QA Needed
|
OGPoyraz
added
Run Smoke E2E
digiwand
previously approved these changes
Jan 15, 2025
OGPoyraz
added
Run Smoke E2E
matthewwalsh0
requested changes
Jan 16, 2025
| @@ -133,8 +133,7 @@ const AccountConnect = (props: AccountConnectProps) => { | |||
|
|
|||
| const { toastRef } = useContext(ToastContext); | |||
|
|
|||
| // origin is set to the last active tab url in the browser which can conflict with sdk | |||
| const inappBrowserOrigin: string = useSelector(getActiveTabUrl, isEqual); | |||
| const origin: string = approvalRequest?.requestData?.origin; | |||
There was a problem hiding this comment.
Is the origin not on the approvalRequest itself as it's part of every approval request?
There was a problem hiding this comment.
Thanks Matthew, you're totally right, fixed.
OGPoyraz
added
No E2E Smoke Needed
|
|
OGPoyraz
added
Run Smoke E2E
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to make connect and send flows to exclusively use approval origin.
Related issues
Fixes: https://github.com/MetaMask/mobile-planning/issues/2096
Manual testing steps
See task for repro steps
Screenshots/Recordings
Simulator.Screen.Recording.-.iPhone.13.Pro.-.2025-01-14.at.15.41.23.mp4
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist