Use patch-package #1304
Merged
Use patch-package #1304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* use patch package * update lockfile
Andepande
pushed a commit
that referenced
this pull request
Oct 18, 2023
## **Description** _Identical to #7519 but targeting the release branch due to additional patch changes not yet being released._ Resolve a bug causing some new transactions to be stuck in the `submitted` status as they are rejected by the network due to `nonce` values that are too high. This is caused by incorrect callbacks in the `NonceTracker` in the `TransactionController`, resulting in correct `nonce` values being skipped because a local confirmed transaction (with the same address but a different chain ID) has the same `nonce`. The solution is to update the callbacks used by the `NonceTracker` to filter transactions to the current chain only. ## **Manual testing steps** 1. Create a new account. 2. Send some Goerli to the account. 3. Send some Sepolia to the account. 4. Send a transaction on Goerli using the new account. 5. Send a transaction on Sepolia using the new account. 6. Verify both are successful and both using the same nonce. ## **Related issues** Fixes [#1304](MetaMask/mobile-planning#1304) ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained: - [x] What problem this PR is solving. - [x] How this problem was solved. - [x] How reviewers can test my changes. - [x] I’ve indicated what issue this PR is linked to: Fixes #??? - [x] I’ve included tests if applicable. - [x] I’ve documented any added code. - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). - [x] I’ve properly set the pull request status: - [x] In case it's not yet "ready for review", I've set it to "draft". - [x] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up the postinstall script and now use patch-package instead of sed