Device util update #1342
Merged
Device util update #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickycodes
force-pushed
the
device-util-update
branch
2 times, most recently
from
2f8044d
to
d25d997
Compare
estebanmino
reviewed
Feb 15, 2020
rickycodes
force-pushed
the
device-util-update
branch
from
d25d997
to
605043d
Compare
rickycodes
force-pushed
the
device-util-update
branch
from
605043d
to
7a48307
Compare
rickycodes
added a commit
that referenced
this pull request
Jan 31, 2022
* DeviceSize -> Device * Add isAndroid() and isIos() methods in Device and use throughout * Add Device.test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While this PR looks massive it actually only does a few things:
Platform.OS === 'android'into a singleDeviceutility with methodsisAndroid()andisIos()DeviceSize.jsutility is deleted and moved toDevice.jsDevice.test.jsfor the device methods we're using (previously untested).Checklist