Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detox: Fix wallet tests #1394

Merged
merged 2 commits into from
Mar 3, 2020
Merged

Detox: Fix wallet tests #1394

merged 2 commits into from
Mar 3, 2020

Conversation

ibrahimtaveras00
Copy link
Contributor

This PR fixes the file wallet-tests.spec.js which is now passing on both OS's

seen here = https://recordit.co/RpgXmFRpp3

} else {
await TestHelpers.typeTextAndHideKeyboard('txn-to-address-input', VALID_ADDRESS);
}
await TestHelpers.replaceTextInField('txn-to-address-input', VALID_ADDRESS);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no problems with ios?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good on iOS (it speeds up the test a bit too) = https://recordit.co/WEyV4Mj1Kg

Screen Shot 2020-03-03 at 1 32 53 PM

Copy link
Contributor

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ibrahimtaveras00 ibrahimtaveras00 merged commit e16366a into develop Mar 3, 2020
@ibrahimtaveras00 ibrahimtaveras00 deleted the detox/fix-wallet-tests branch March 3, 2020 18:37
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants