Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detox: Fix Browser Tests #1397

Merged
merged 1 commit into from
Mar 3, 2020

Conversation

ibrahimtaveras00
Copy link
Contributor

This PR fixes the failed browser-tests.spec.js file in e2e tests

Screen Shot 2020-03-02 at 7 24 57 PM

This will work fine in release mode, however, fails in debug mode because of #1395

If you add that warning to index.js then it works, however, this is not ideal as we would want to see that warning.

Copy link
Contributor

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ibrahimtaveras00 ibrahimtaveras00 merged commit fc600fa into develop Mar 3, 2020
@ibrahimtaveras00 ibrahimtaveras00 deleted the detox/fix-warning-on-browser-test branch March 3, 2020 18:07
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants