Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: payment request #1411

Merged
merged 3 commits into from
Mar 10, 2020
Merged

bugfix: payment request #1411

merged 3 commits into from
Mar 10, 2020

Conversation

estebanmino
Copy link
Contributor

Description

Fixes #1405

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

@estebanmino estebanmino added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Mar 10, 2020
ibrahimtaveras00
ibrahimtaveras00 approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good now, QA Passed 👍

rekmarks
rekmarks approved these changes Mar 10, 2020
View reviewed changes
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@estebanmino estebanmino merged commit 1b57b19 into develop Mar 10, 2020
@whymarrh whymarrh deleted the bugfix/payment-request branch March 19, 2020 03:07
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@estebanmino
bugfix: payment request (#1411)
9355c1f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rekmarks rekmarks rekmarks approved these changes

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

@danjm danjm Awaiting requested review from danjm

@rickycodes rickycodes Awaiting requested review from rickycodes

Assignees
No one assigned
Labels
needs-qa Any New Features that needs a full manual QA prior to being added to a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Going through Receive > Request flow causes txn error
3 participants
@estebanmino @rekmarks @ibrahimtaveras00