Gaba assets controllers integration #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunobar79
suggested changes
Oct 11, 2018
app/util/number.js
Outdated
| * @returns {number} - Number | ||
| */ | ||
| export function toNumber(value, decimals) { | ||
| return value.toNumber() / Math.pow(10, decimals); |
There was a problem hiding this comment.
I think you can do value.toFormat(decimals)
scripts/postinstall.sh
Outdated
| @@ -3,6 +3,7 @@ echo "PostInstall script:" | |||
|
|
|||
| echo "1. React Native nodeify..." | |||
| node_modules/.bin/rn-nodeify --install 'crypto,buffer,react-native-randombytes,vm,stream' --hack | |||
There was a problem hiding this comment.
have you tried adding gaba in this line instead?
node_modules/.bin/rn-nodeify --install 'crypto,buffer,react-native-randombytes,vm,stream,gaba' --hack
There was a problem hiding this comment.
yes I tried, is super strange to be honest. I'll reach out on slack when I start making this changes.
estebanmino
changed the title
Closed
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* GABA AssetsDetectionController integration * Fix CollectibleImage address * GABA with web3 integration and collectible image bugfix * integrate AssetsContractController * integration of GABA TokenBalancesController * update snapshots * fix empty collectible image URI * add new controllers to engine tests * update gaba to last version * fix some gaba dependencies * update calculate token value
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR acts together with MetaMask/core#19, providing assets auto detection and token balances.
Specifically it adds three controllers from GABA:
AssetsDetectionController: In charge of auto detect assets when, network changes to mainnet or current account changes, while mainnet.AssetsContractController: In charge ofweb3interaction with assets controller. Important in this PR because it modifies the way GABA is used withrn-nodeifyhttps://github.com/MetaMask/MetaMask/blob/d5ad3653a2f8bad28e19bcfdd38c3ad04140524e/scripts/postinstall.sh#L6TokenBalancesController: In charge of balances update from current token list.And use of
TokenRatesController, to get fiat value of tokens together with token balances.Checklist
Issue
Related MetaMask/website#61
BLOCKER: Correct GABA version.
https://github.com/MetaMask/MetaMask/blob/d5ad3653a2f8bad28e19bcfdd38c3ad04140524e/package.json#L60
Resolves #63
Comments: Address in GIF was hard coded.