Splash screen on android #1554
Merged
Splash screen on android #1554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrepimenta
changed the title
andrepimenta
added
the
needs-qa
danjm
approved these changes
May 12, 2020
ibrahimtaveras00
approved these changes
May 29, 2020
ibrahimtaveras00
added
QA Passed
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* splash screen installed and working on android * ios comment for more details * Update Podfile.lock * Fix no new line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes addresses the "Android performance issue: time to first paint". There was a display of a blank screen when first loading the app, now addressed by adding a native splash screen.
Since it is not possible to add an animated splash screen (or even a gif), it was decided to add a static shape that turns into animation once react native is loaded.
I am still not sure if this looks better than before, WDYT @cjeria ?
@ibrahimtaveras00 I think it is very important to test this on different screen sizes, just to make sure the splash screen is always aligned with the animation.
Issue
Resolves #1542