Payment channel opt in #1573
Merged
Payment channel opt in #1573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danjm
reviewed
May 13, 2020
| componentDidMount = async () => { | ||
| const paymentChannelHasBalance = await PaymentChannelsClient.addressHasBalance(this.props.selectedAddress); | ||
| if (paymentChannelHasBalance) this.setState({ paymentChannelHasBalance }); | ||
| this.setState({ paymentChannelHasBalance: true }); |
There was a problem hiding this comment.
I think line 84 can be deleted
| * Returns whether the address has balance in channel | ||
| */ | ||
| addressHasBalance: async address => { | ||
| if (client) return true; |
There was a problem hiding this comment.
Is it possible for a client to have been initialized but no balance sent to the address?
There was a problem hiding this comment.
yes, just enabling the experimental setting with the channel just opened
andrepimenta
added
needs-qa
ibrahimtaveras00
added
the
needs-qa
ibrahimtaveras00
suggested changes
Jul 2, 2020
There was a problem hiding this comment.
Issue 1
I am unable to enable payment channels on an account that has a balance
steps:
- I started in a state where instapay was already enabled on the app (came from develop branch)
- built this branch and saw instapay was still enabled with the correct balance
- I then toggled off/disabled state channels on that account
- switched to another account that didn't have any instapay balance
- killed the app and relaunched
- switched back to the account that DOES have an instapay balance
- however, when I attempted to enable payment channels, I didn't have the option to do so
Issue 2
I don't see the option to enable payment channels when importing via seed phrase
- started app in fresh state
- imported my wallet via seed phrase
- once I got to the wallet view I went to settings > experimental
- I did not see the option to enable payment channels even though my Account 1 does indeed have instapay funds
ibrahimtaveras00
added
QA'd - Issues Found
ibrahimtaveras00
approved these changes
Jul 8, 2020
ibrahimtaveras00
added
QA Passed
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* check for balance * snaps? * stop client * stop client * paymentChannelHasBalance * ip has txs * local * snapshots Co-authored-by: Ibrahim Taveras <ibrahimtaveras00@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will hide the option for turning on payment channel if no funds on the channel for current
selectedAddressandprovider.typeChecklist
Issue
Resolves #???