Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/sync imported accounts from extension #1591

Merged
merged 15 commits into from
Jun 26, 2020
Merged

feature/sync imported accounts from extension #1591

merged 15 commits into from
Jun 26, 2020

Conversation

estebanmino
Copy link
Contributor

@estebanmino estebanmino commented May 20, 2020 •
edited by ibrahimtaveras00
Loading

Description

Sync imported accounts coming from extension. Related PR on extension MetaMask/metamask-extension#8631
Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

#1006

@estebanmino estebanmino mentioned this pull request May 20, 2020
Merged
@estebanmino estebanmino changed the title feature/sync-imported-accounts feature/sync imported accounts from extension May 20, 2020
andrepimenta
andrepimenta approved these changes May 22, 2020
View reviewed changes
Copy link
Member

@andrepimenta andrepimenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ibrahimtaveras00 ibrahimtaveras00 added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label May 29, 2020
@ibrahimtaveras00 ibrahimtaveras00 requested a review from a team as a code owner May 29, 2020 22:11
@ibrahimtaveras00 ibrahimtaveras00 added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jun 25, 2020
ibrahimtaveras00
ibrahimtaveras00 approved these changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on both OS's, QA Passed 👍

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Jun 25, 2020
@estebanmino estebanmino added the DO-NOT-MERGE Pull requests that should not be merged label Jun 26, 2020
@estebanmino estebanmino removed the DO-NOT-MERGE Pull requests that should not be merged label Jun 26, 2020
@estebanmino estebanmino merged commit befd132 into develop Jun 26, 2020
@estebanmino estebanmino deleted the feature/sync-imported-accounts branch June 26, 2020 18:38
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@estebanmino @ibrahimtaveras00
feature/sync imported accounts from extension (#1591)
deeb062 
* feature/sync-imported-accounts

* enable-apple-pay

* analytics only on not dev

* startwatcher

* dev

* env.

* importedAccounts check

Co-authored-by: Ibrahim Taveras <ibrahimtaveras00@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrepimenta andrepimenta andrepimenta approved these changes

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@estebanmino @andrepimenta @ibrahimtaveras00 @omnat