Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect design qa #1604

Merged
merged 4 commits into from
May 30, 2020
Merged

Connect design qa #1604

merged 4 commits into from
May 30, 2020

Conversation

EtDu
Copy link
Contributor

@EtDu EtDu commented May 29, 2020

Description

Write a short description of the changes included in this pull request.

Checklist

  • QA fixes

Issue

Resolves #1603

@EtDu EtDu requested a review from a team as a code owner May 29, 2020 04:47
@ibrahimtaveras00 ibrahimtaveras00 added needs-qa Any New Features that needs a full manual QA prior to being added to a release. next release labels May 29, 2020
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good on both OS's, QA Passed 👍

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels May 29, 2020
@EtDu EtDu merged commit 7c9f7ca into develop May 30, 2020
@EtDu EtDu deleted the connect-design-qa branch May 30, 2020 04:44
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
* qa fixes

* AccountInfoCard: render fiat value with 2 decimals to fix padding overflow on small screens

* yet another snapshot update

* stubborn snapshots be stubborn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next release QA Passed A successful QA run through has been done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connect Screen QA Issues
2 participants