Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix word election error in Spanish #1605

Merged
merged 6 commits into from
Jul 2, 2020
Merged

Conversation

Pedro-vk
Copy link
Contributor

Description

"Llave" is key but is used only for keys that open doors. "Clave" is key too but is used as "secret".

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

"Llave" is key but is used only for keys that open doors. "Clave" is key too but is used as "secret".
@Pedro-vk Pedro-vk requested a review from a team as a code owner May 29, 2020 18:04
@omnat
Copy link
Contributor

omnat commented Jun 22, 2020

Hi @Pedro-vk thanks for this improvement suggestion. This word's translation is correct for some regional Spanish versions. So we're considering keeping it as is. Let us know if you have strong opinions on changing this.

@Pedro-vk
Copy link
Contributor Author

Hi @Pedro-vk thanks for this improvement suggestion. This word's translation is correct for some regional Spanish versions. So we're considering keeping it as is. Let us know if you have strong opinions on changing this.

I think that you should make this change for several reasons:

It's true that probably in South America is used (don't know, but possible because sometimes is used a very literal translation of English for technical words)

Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@estebanmino estebanmino merged commit 0c1f67d into MetaMask:develop Jul 2, 2020
@estebanmino
Copy link
Contributor

thanks @Pedro-vk !

rickycodes pushed a commit that referenced this pull request Jan 31, 2022
"Llave" is key but is used only for keys that open doors. "Clave" is key too but is used as "secret".

Co-authored-by: Esteban Miño <efmino@uc.cl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants