Feature/security third party api mode #1609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estebanmino
changed the title
estebanmino
added
the
needs-qa
ibrahimtaveras00
suggested changes
Jul 2, 2020
There was a problem hiding this comment.
For some reason it seems that the metametrics option is being disabled by default even though when I created my new wallet, I agreed and even further tried to enable it via settings but it doesn't stick; seen here = http://recordit.co/mKPBMVur9W
ibrahimtaveras00
added
QA'd - Issues Found
|
That issue doesn't pertain to this PR as it happens on develop branch, so with that said this PR is QA Passed 👍 |
ibrahimtaveras00
added
QA Passed
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* settings * third party api mode * strings * spanish love * tests * test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a toggle under Security & Privacy settings to turn on / off the usage of third party APIs, as Etherscan to get incoming transactions in the user transaction history.
Checklist
Issue
Resolves #???