Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix branch #1621

Merged
merged 10 commits into from
Jun 9, 2020
Merged

Fix branch #1621

merged 10 commits into from
Jun 9, 2020

Conversation

estebanmino
Copy link
Contributor

@estebanmino estebanmino commented Jun 6, 2020

Description

This PR fixed react-native-branch integration, now deeplinks are working on both ios and android, using latest version so we can remove https://github.com/MetaMask/react-native-branch-deep-linking-attribution

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

@estebanmino estebanmino marked this pull request as ready for review June 9, 2020 03:52
@estebanmino estebanmino requested a review from a team as a code owner June 9, 2020 03:52
Copy link
Member

@andrepimenta andrepimenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on both OS's, QA Passed 👍

@ibrahimtaveras00 ibrahimtaveras00 added the QA Passed A successful QA run through has been done label Jun 9, 2020
@estebanmino estebanmino merged commit 3890e17 into develop Jun 9, 2020
@estebanmino estebanmino deleted the fix-branch branch June 9, 2020 22:09
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
* env android

* working

* android working

* handle from entry

* handle ios|

* ios working

* ios and android working

* modify script

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA Passed A successful QA run through has been done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants