Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix browser intial load #1623

Merged
merged 3 commits into from
Jun 10, 2020
Merged

Conversation

andrepimenta
Copy link
Member

@andrepimenta andrepimenta commented Jun 10, 2020

Description

Fix the issue of not having the script on the first load of a dapp

@andrepimenta andrepimenta requested a review from a team as a code owner June 10, 2020 18:34
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on both OS's, QA Passed 👍

@andrepimenta andrepimenta requested a review from a team June 10, 2020 19:26
@estebanmino estebanmino merged commit 4e41b80 into develop Jun 10, 2020
@estebanmino estebanmino deleted the improvement/fix-browser-initial-load branch June 10, 2020 20:15
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
* Fix browser intial load

* Fix unit testing

Co-authored-by: Esteban Miño <efmino@uc.cl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants