Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet connect update + Support for simple notifications #1624

Merged
merged 41 commits into from
Jun 11, 2020

Conversation

estebanmino
Copy link
Contributor

Description

Write a short description of the changes included in this pull request.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

@estebanmino estebanmino requested a review from a team as a code owner June 11, 2020 16:55
@estebanmino estebanmino marked this pull request as draft June 11, 2020 16:55
@estebanmino estebanmino changed the title Wallet connect upgrade Wallet connect upgrade + Support for simple notifications Jun 11, 2020
@estebanmino estebanmino marked this pull request as ready for review June 11, 2020 20:34
Copy link
Member

@rickycodes rickycodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@estebanmino estebanmino changed the title Wallet connect upgrade + Support for simple notifications Wallet connect update + Support for simple notifications Jun 11, 2020
@estebanmino estebanmino merged commit 4a4c14b into develop Jun 11, 2020
@estebanmino estebanmino deleted the wallet-connect-upgrade branch June 11, 2020 21:14
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
* bump

* client|

* env android

* working

* android working

* handle from entry

* images

* handle not valid uris

* handle ios|

* ios working

* ios and android working

* modify script

* fix

* small update

* check params

* bump

* use of approval

* base notification

* refactor

* change name

* didn't break anything

* still working

* simple notifications working

* show simple not

* origin

* show notifications

* locales

* status

* locales

* reducer:

* lines

* nots

* undo sh

* add entry to changelog

* add entry to changelog

* add entry to changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants