Add ETH_GAS_STATION_API_KEY #1653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estebanmino
pushed a commit
that referenced
this pull request
Jun 29, 2020
estebanmino
pushed a commit
that referenced
this pull request
Jun 29, 2020
estebanmino
pushed a commit
that referenced
this pull request
Jun 30, 2020
rickycodes
added a commit
that referenced
this pull request
Jan 31, 2022
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 7, 2024
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> * This is the actual first implementation of the LaunchDarkly API for feature flags * This utilizes the `mobileMinimumVersions.appMinimumBuild` feature flag in LaunchDarkly ## **Related issues** Fixes: [#1653](MetaMask/mobile-planning#1653) This PR builds upon work in previous LD setup work: [#10294](#10294) ## **Manual testing steps** 1. Start the app 2. in `app/components/hooks/MinimumVersions/useMinimumVersions.tsx` * Change line: 22 `featureFlags?.mobileMinimumVersions?.appMinimumBuild > currentBuildNumber;` to: `featureFlags?.mobileMinimumVersions?.appMinimumBuild > 0;` 3. Restart app & enter password 4. Modal should popup prompting user to update app version ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** https://github.com/user-attachments/assets/812fb49d-e79b-4b3f-8f5e-00d3b63a431f ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Nico MASSART <NicolasMassart@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.