Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update review function names #1657

Merged
merged 4 commits into from
Jul 16, 2020
Merged

update review function names #1657

merged 4 commits into from
Jul 16, 2020

Conversation

estebanmino
Copy link
Contributor

@estebanmino estebanmino commented Jun 29, 2020 •
edited
Loading

Description

  • Camel cased
  • Contract Interaction instead of Unknown Method

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

@estebanmino estebanmino requested a review from a team as a code owner June 29, 2020 19:36
andrepimenta
andrepimenta approved these changes Jul 2, 2020
View reviewed changes
Copy link
Member

@andrepimenta andrepimenta left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question:
Sometimes we use "Despliegue de contrato" (Uppercase on the first word and the rest lower case) and other times we use "Contrato Desplegado" or "Interacción con Contrato" (Uppercases after the first word). Is this intentional?

Otherwise, LGTM! 👍

@ibrahimtaveras00
Copy link
Contributor

ibrahimtaveras00 commented Jul 3, 2020 •
edited
Loading

Also looks like there is still some discussion in regards to the actual naming convention to be used

https://consensys.slack.com/archives/GBW7S9FSN/p1593640717020500?thread_ts=1593450065.002100&cid=GBW7S9FSN

CC: @cjeria @omnat

@ibrahimtaveras00 ibrahimtaveras00 added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Jul 3, 2020
ibrahimtaveras00
ibrahimtaveras00 approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on both OS's, QA Passed 👍

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jul 16, 2020
@estebanmino estebanmino merged commit bdbe185 into develop Jul 16, 2020
@estebanmino estebanmino deleted the update-review-function-names branch July 16, 2020 16:59
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@estebanmino
update review function names (#1657)
517ae7f 
* update

* snapshot

* :unknown:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrepimenta andrepimenta andrepimenta approved these changes

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

Assignees
No one assigned
Labels
next release QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@estebanmino @ibrahimtaveras00 @andrepimenta