Feature/account backup alert flows #1681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Warn me if I want to sync a different wallet * remove existing user check from importwallet * locales
* send to choosepassword * gotowallet * protect wallet modal * text * working * decrypt with empty password * hash commit
* Warn me if I want to sync a different wallet * remove existing user check from importwallet * locales * update alert * update alert * own component * redux * trigger modal everywhere * show modal only if seedphare not backed * add more cases * onLearnMore * locales * show border only if vertical
estebanmino
added
the
needs-qa
|
@andrepimenta this PR should be merged after the new bundle of seedphrase PRs is merged |
ibrahimtaveras00
added
QA in Progress
rickycodes
approved these changes
Jul 14, 2020
| {displayCancelButton && ( | ||
| <StyledButton | ||
| testID={cancelTestID} | ||
| type={cancelButtonMode} | ||
| onPress={onCancelPress} | ||
| containerStyle={[styles.button, displayConfirmButton ? styles.cancel : {}]} | ||
| containerStyle={[styles.button, verticalButtons ? {} : styles.buttonHorizontal]} |
There was a problem hiding this comment.
instead of using a ternary here, could we do?:
!verticalButtons && styles.buttonHorizontal
| @@ -83,7 +89,7 @@ export default function ActionContent({ | |||
| testID={confirmTestID} | |||
| type={confirmButtonMode} | |||
| onPress={onConfirmPress} | |||
| containerStyle={[styles.button, displayCancelButton ? styles.confirm : {}]} | |||
| containerStyle={[styles.button, verticalButtons ? {} : styles.buttonHorizontal]} | |||
| <Text style={styles.protectWalletContent}> | ||
| {!this.props.passwordSet | ||
| ? strings('protect_your_wallet_modal.body_for_password') | ||
| : strings('protect_your_wallet_modal.body_for_seedphrase')} |
There was a problem hiding this comment.
this could instead be:
{strings(`protect_your_wallet_modal.body_for_${!this.props.passwordSet ? 'password' : 'seedphrase' }`)}
while this is a bit more DRY it might be easier to read the other way?
ibrahimtaveras00
added
needs-qa
ibrahimtaveras00
added
QA in Progress
ibrahimtaveras00
added
QA Passed
ibrahimtaveras00
approved these changes
Jul 30, 2020
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* Warn if different wallet (#1677) * Warn me if I want to sync a different wallet * remove existing user check from importwallet * locales * Create password if not set (#1678) * send to choosepassword * gotowallet * protect wallet modal * text * working * decrypt with empty password * hash commit * Feature/backup seedphrase (#1680) * Warn me if I want to sync a different wallet * remove existing user check from importwallet * locales * update alert * update alert * own component * redux * trigger modal everywhere * show modal only if seedphare not backed * add more cases * onLearnMore * locales * show border only if vertical * changes * comments * show modal * add warning * Device.isIphoneX * snaps * AccountBackupStep1 * skip modal * create password * padding horizontal * snaps * enabled| * fix init * fix create password * modal * WarningExistingUserModal * snaps * AddressQRCode * onSecureWalletModalAction * bool * touchable * fix? * snaps * if passwordset * protectWalletModalNotVisible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Collection of PRs related to backup alerts
https://trello.com/c/oioLEgpq/131-warn-me-if-i-want-to-sync-a-different-wallet
https://trello.com/c/yyGN7hg5/135-prompt-me-to-save-my-seedphrase-in-different-scenarios
https://trello.com/c/Nd8wuBUH/134-prompt-me-to-create-a-password-if-i-dont-have-one
Checklist
Issue
Resolves #???