Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/speedup transactions #1684

Merged
merged 8 commits into from
Jul 16, 2020
Merged

Bugfix/speedup transactions #1684

merged 8 commits into from
Jul 16, 2020

Conversation

estebanmino
Copy link
Contributor

Description

The validation method was wrong. I also moved it to an method in utils.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

@estebanmino estebanmino requested a review from a team as a code owner July 8, 2020 21:13
@estebanmino estebanmino added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Jul 8, 2020
@estebanmino estebanmino changed the base branch from develop to bugfix/release-bugs July 9, 2020 16:53
@estebanmino estebanmino changed the base branch from bugfix/release-bugs to develop July 9, 2020 16:53
ibrahimtaveras00
ibrahimtaveras00 suggested changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Speeding up and canceling work fine on regular send flow 👍

Issue 1:

I did a token swap on uniswap, however, when I tapped on the speed up button nothing happened and I got the following warning:

{"code": -32000, "message": "insufficient funds for gas * price + value"}

Seen here = https://recordit.co/DCyD54MJTm

Screen Shot 2020-07-09 at 9 58 20 PM

Issue 2:

I believe the button's color should be updated to primary-blue

@ibrahimtaveras00 ibrahimtaveras00 added QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jul 10, 2020
andrepimenta
andrepimenta approved these changes Jul 14, 2020
View reviewed changes
Copy link
Member

@andrepimenta andrepimenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@estebanmino
Copy link
Contributor Author

added a change for that issue on MetaMask/core#249

@estebanmino estebanmino added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed labels Jul 15, 2020
ibrahimtaveras00
ibrahimtaveras00 suggested changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only remaining issue is the color of the speed up and cancel CTA when tapping on the notification to bring up the txn history modal, then tapping on either speed up or cancel

Screen Shot 2020-07-16 at 12 24 27 PM

Screen Shot 2020-07-16 at 12 27 40 PM

@ibrahimtaveras00 ibrahimtaveras00 added QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jul 16, 2020
ibrahimtaveras00
ibrahimtaveras00 approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good, QA Passed 👍

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed labels Jul 16, 2020
@estebanmino estebanmino merged commit d709f32 into develop Jul 16, 2020
@estebanmino estebanmino deleted the bugfix/speedup-transactions branch July 16, 2020 17:39
@estebanmino estebanmino mentioned this pull request Jul 29, 2020
Closed
@ibrahimtaveras00 ibrahimtaveras00 mentioned this pull request Aug 4, 2020
Closed
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@estebanmino
Bugfix/speedup transactions (#1684)
f03ab29 
* add padding

* create util

* new gaba

* buttons color

* confirmButtonMode={'confirm'}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrepimenta andrepimenta andrepimenta approved these changes

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

Assignees
No one assigned
Labels
next release QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@estebanmino @andrepimenta @ibrahimtaveras00