Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Gas + Data hotfixes #1687

Merged
merged 9 commits into from
Jul 17, 2020
Merged

Custom Gas + Data hotfixes #1687

merged 9 commits into from
Jul 17, 2020

Conversation

EtDu
Copy link
Contributor

@EtDu EtDu commented Jul 9, 2020 •
edited
Loading

@EtDu EtDu requested a review from a team as a code owner July 9, 2020 04:26
estebanmino
estebanmino approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estebanmino estebanmino added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Jul 9, 2020
ibrahimtaveras00
ibrahimtaveras00 suggested changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the data, however, it's not scrollable to show me all of the data as compared to extension; seen here = https://recordit.co/7WyO7lKu4u

Screen Shot 2020-07-09 at 9 38 42 PM

@ibrahimtaveras00 ibrahimtaveras00 added QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jul 10, 2020
@EtDu
Copy link
Contributor Author

EtDu commented Jul 10, 2020

@ibrahimtaveras00 should be good

@andrepimenta andrepimenta added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed labels Jul 14, 2020
ibrahimtaveras00
ibrahimtaveras00 suggested changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have my currency set to fiat, and upon clicking on deploy contract on https://metamask.github.io/test-dapp/ site to test if data is scrollable the app crashed; seen here = http://recordit.co/UwSOKhH9nb

Screen Shot 2020-07-14 at 9 16 56 PM

although it does look like the deeplink issue was fixed when fiat is set = http://recordit.co/AXjBl8Vud7

Also, when primary currency is set to native, I see this warning when tapping on deploy contract

Screen Shot 2020-07-14 at 9 20 43 PM

@ibrahimtaveras00 ibrahimtaveras00 added QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jul 15, 2020
@EtDu EtDu added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed labels Jul 15, 2020
ibrahimtaveras00
ibrahimtaveras00 approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All issues have been resolved, QA Passed

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jul 16, 2020
@EtDu EtDu merged commit 0846d4c into develop Jul 17, 2020
@EtDu EtDu deleted the customGas-hotfixes branch July 17, 2020 05:20
@EtDu EtDu mentioned this pull request Jul 17, 2020
Closed
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@EtDu
Custom Gas + Data hotfixes (#1687)
ef9137f 
* CustomGas: fix crash when navigating back to advanced gas during error

* TransactionReviewData: fix data not displaying

* fix snapshit test

* TransactionReviewData: fix data not scrollable

* snapsho

* SendFlow: fix total fiat to be text component when passed down to TransactionReviewFeeCard

* snapshotsssss baby

* TransactionReviewInformation: fix totalFiat is now a Text component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estebanmino estebanmino estebanmino approved these changes

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

Assignees
No one assigned
Labels
next release QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EtDu @estebanmino @ibrahimtaveras00 @andrepimenta