Lock KeyringController on logout #1729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickycodes
added
the
needs-dev-review
andrepimenta
added
the
needs-qa
omnat
removed
the
needs-dev-review
rickycodes
force-pushed
the
feature/lock-KeyringController
branch
4 times, most recently
from
40bde65
to
757b802
Compare
rickycodes
force-pushed
the
feature/lock-KeyringController
branch
from
757b802
to
891e465
Compare
rickycodes
force-pushed
the
feature/lock-KeyringController
branch
from
891e465
to
e0a1f75
Compare
ibrahimtaveras00
suggested changes
Aug 11, 2020
There was a problem hiding this comment.
The only issue I've found here is on iOS
- I came from the testflight build 0.2.19 and then synced with extension with Face ID enabled
- I then built this branch and built to the real device
- Once I was prompted for Face ID I saw the check mark, however, it didn't unlock the app
seen here = https://recordit.co/IbI0JRu9jN
I couldn't reproduce this on Android with an imported account nor fingerprint with a wallet synced with extension = https://recordit.co/sSRW7PpGgr
ibrahimtaveras00
added
QA'd - Issues Found
ibrahimtaveras00
added
QA Passed
rickycodes
added a commit
that referenced
this pull request
Jan 31, 2022
* Lock KeyringController on logout * Also call .setLocked() on KeyringController for LockScreen * Lock KeyringController on lockApp() instead * Undo async * Add setLockedErrora and gotoLockScreen methods Co-authored-by: Andre Pimenta <andrepimenta7@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on feedback from @Gudahtt we now lock the
KeyringControllerwhen welogoutand when welockApp