Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy edits #1732

Merged
merged 7 commits into from
Aug 5, 2020
Merged

Copy edits #1732

merged 7 commits into from
Aug 5, 2020

Conversation

rickycodes
Copy link
Member

@rickycodes rickycodes commented Jul 29, 2020 •
edited
Loading

Sync with extension text:

Before:

image

After:

image

Sync with extension steps text:

Before:

image

After:

image

Private key warning text

Before:

image

After:

image

Seed phrase warning text

Before:

image

After:

image

@rickycodes rickycodes requested a review from a team as a code owner July 29, 2020 16:37
@rickycodes rickycodes force-pushed the feature/update-private-key-warning branch 3 times, most recently from aef904b to acf7d03 Compare July 31, 2020 15:17
@rickycodes rickycodes force-pushed the feature/update-private-key-warning branch from acf7d03 to 4d844d8 Compare August 4, 2020 15:47
@rickycodes rickycodes changed the title Update private key warning Copy edits Aug 4, 2020
@rickycodes rickycodes added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 5, 2020
ibrahimtaveras00
ibrahimtaveras00 approved these changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Passed 👍

@ibrahimtaveras00 ibrahimtaveras00 added the QA Passed A successful QA run through has been done label Aug 5, 2020
@estebanmino estebanmino merged commit 6a9b700 into develop Aug 5, 2020
@estebanmino estebanmino deleted the feature/update-private-key-warning branch August 5, 2020 23:18
rickycodes added a commit that referenced this pull request Jan 31, 2022
@rickycodes @estebanmino
Copy edits (#1732)
8759f5f 
* Update private key warning

* Update snapshots

* Replace "Scan QR code" with "Sync with MetaMask extension"

* Replace "Scan QR code steps" with "Steps to sync with MetaMask extension"

* Update seed_warning value

* Update snapshot

Co-authored-by: Esteban Miño <efmino@uc.cl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estebanmino estebanmino estebanmino approved these changes

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

Assignees
No one assigned
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rickycodes @estebanmino @ibrahimtaveras00