bugfix/payment requests & deeplinks #1751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickycodes
approved these changes
Aug 5, 2020
estebanmino
changed the title
This reverts commit 7a7941c.
estebanmino
added
needs-qa
estebanmino
commented
Aug 6, 2020
| !existingUser ? DeeplinkManager.setDeeplink(deeplink) : DeeplinkManager.parse(deeplink); | ||
| const { KeyringController } = Engine.context; | ||
| const isUnlocked = KeyringController.isUnlocked(); | ||
| isUnlocked ? DeeplinkManager.parse(deeplink) : DeeplinkManager.setDeeplink(deeplink); |
There was a problem hiding this comment.
we're checking if keyring is unlocked to store a deeplink or parse it right away
estebanmino
commented
Aug 6, 2020
app/components/Views/Send/index.js
Outdated
| @@ -292,7 +291,7 @@ class Send extends PureComponent { | |||
| amount: BNToHex(tokenAmount) | |||
| }), | |||
| value: '0x0', | |||
| readableValue: parameters.uint256 || '0' | |||
| readableValue: fromTokenMinimalUnit(parameters.uint256, selectedAsset.decimals) || '0' | |||
There was a problem hiding this comment.
now we have to handle token "atomic" units from deeplinks
estebanmino
commented
Aug 6, 2020
| @@ -436,7 +436,7 @@ class Confirm extends PureComponent { | |||
| contractBalances[address] ? contractBalances[address] : '0', | |||
| decimals | |||
| )} ${symbol}`; | |||
| [transactionTo, , amount] = decodeTransferData('transfer', data); | |||
| [transactionTo, amount] = decodeTransferData('transfer', data); | |||
There was a problem hiding this comment.
we were taking a parsed number from the hex format, now we take the hex number
estebanmino
added
the
needs-dev-review
ibrahimtaveras00
added
QA Passed
rickycodes
approved these changes
Aug 6, 2020
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* use hex number * password set * publish-pre-release-android * Revert "publish-pre-release-android" This reverts commit 7a7941c. * Revert "Revert "publish-pre-release-android"" This reverts commit 303bf2e. * KeyringController.isUnlocked * only isUnlocked * fromTokenMinimalUnit * Revert "Revert "Revert "publish-pre-release-android""" This reverts commit 28ae877. * || '0' * changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were using the parsed decimal number instead of the hex number to get the token amount from the
datahttps://trello.com/c/qhpAxjC1/192-walletconnect-not-working-on-android and https://trello.com/c/ubVPsajC/193-payment-request-deeplink-showing-wrong-amount
Checklist
Issue
Resolves #???