Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to use Blockies Identicon and use Jazz Icons as default #1757

Merged
merged 9 commits into from
Sep 9, 2020
Merged

Add option to use Blockies Identicon and use Jazz Icons as default #1757

merged 9 commits into from
Sep 9, 2020

Conversation

rickycodes
Copy link
Member

@rickycodes rickycodes commented Aug 8, 2020 •
edited
Loading

This gives us a new option to enable blockies Identicons instead of the now default jazzicons thus matching what exists in the extension today:

image

Which of course changes the avatar style that's used to Blockies (what we use currenctly) from the new detault:

image

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #232

@rickycodes rickycodes requested a review from a team as a code owner August 8, 2020 01:07
@rickycodes rickycodes changed the title Add option to use Jazz Icon Add option to use Blockies Identicon and use Jazz Icons as default Aug 8, 2020
@rickycodes rickycodes added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Aug 8, 2020
EtDu
EtDu suggested changes Aug 8, 2020
View reviewed changes
Copy link
Contributor

@EtDu EtDu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, just a couple nitpicks

app/actions/settings/index.js Show resolved Hide resolved
app/components/Views/Settings/AdvancedSettings/index.js Outdated Show resolved Hide resolved
app/components/Views/Settings/AdvancedSettings/index.js Outdated Show resolved Hide resolved
app/components/Views/Settings/AdvancedSettings/index.js Show resolved Hide resolved
rickycodes
rickycodes commented Aug 10, 2020
View reviewed changes
app/components/UI/Identicon/__snapshots__/index.test.js.snap
@@ -1,3 +1,17 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`Identicon should render correctly 1`] = `""`;
Copy link
Member Author

@rickycodes rickycodes Aug 10, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is interesting. I'm not sure why this was empty before? the new snapshot I think makes sense, but maybe this is normal for components created with .memo? maybe the original test wasn't correct?

@rickycodes rickycodes force-pushed the feature/add-jazz-icon-option branch 2 times, most recently from 7c103c2 to 9ce676c Compare August 17, 2020 15:56
@omnat omnat added the next up prioritized to be picked up next label Aug 18, 2020
ibrahimtaveras00
ibrahimtaveras00 suggested changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue 1:

When I switch to use Blockies Identicon I get this warning:

Screen Shot 2020-09-01 at 5 25 56 PM

followed by nothing showing up in it's place

Screen Shot 2020-09-01 at 5 26 30 PM

Screen Shot 2020-09-01 at 5 40 29 PM

Issue 2:

The padding of the Jazz Icons on account info seems off compared to blockies

image

@ibrahimtaveras00 ibrahimtaveras00 added QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Sep 1, 2020
@rickycodes
Copy link
Member Author

rickycodes commented Sep 2, 2020 •
edited
Loading

@ibrahimtaveras00 good catches on this one! should be good now :)

@rickycodes rickycodes added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed labels Sep 2, 2020
ibrahimtaveras00
ibrahimtaveras00 approved these changes Sep 8, 2020
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes look good on both OS's, QA Passed 👍

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Sep 8, 2020
@rickycodes rickycodes merged commit 1cc7168 into develop Sep 9, 2020
@rickycodes rickycodes deleted the feature/add-jazz-icon-option branch September 9, 2020 00:37
rickycodes added a commit that referenced this pull request Jan 31, 2022
@rickycodes
Add option to use Blockies Identicon and use Jazz Icons as default (#…
4838bfa 
…1757)

* Add option to use Jazz Icon

* Update snapshots

* Update test for Identicon to inclue mock store

* Update tests :)

* Address some review nits

* Document some things and remove unused desc (for now)

* Use const for image

* Fix Invalid prop

* Account for customStyle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EtDu EtDu EtDu approved these changes

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

Assignees
No one assigned
Labels
next up prioritized to be picked up next QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jazzicons?
4 participants
@rickycodes @EtDu @ibrahimtaveras00 @omnat