Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix/cancel dapp tx when inactive #1772

Merged
merged 4 commits into from
Aug 14, 2020
Merged

bugfix/cancel dapp tx when inactive #1772

merged 4 commits into from
Aug 14, 2020
+15 −5

Conversation

estebanmino
Copy link
Contributor

Description

This PR cancels transactions suggested by dapps when the app goes to inactive state.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #1771

@estebanmino estebanmino requested a review from a team as a code owner August 13, 2020 21:15
@estebanmino estebanmino added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) next release labels Aug 13, 2020
andrepimenta
andrepimenta approved these changes Aug 13, 2020
View reviewed changes
Copy link
Member

@andrepimenta andrepimenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@estebanmino estebanmino removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 13, 2020
ibrahimtaveras00
ibrahimtaveras00 approved these changes Aug 14, 2020
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Passed 👍

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Aug 14, 2020
@estebanmino estebanmino merged commit 19593ce into develop Aug 14, 2020
@estebanmino estebanmino deleted the bugfix/cancel-dapp-tx-when-inactive branch August 14, 2020 19:43
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@estebanmino
bugfix/cancel dapp tx when inactive (#1772)
2968bf3 
* fix

* check transaction.id

* background android

* appState !== 'active'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

@andrepimenta andrepimenta andrepimenta approved these changes

Assignees
No one assigned
Labels
next release QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App crashing on launch possibly due to a pending tx state
3 participants
@estebanmino @andrepimenta @ibrahimtaveras00