Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MMM not respecting Wallet Connect gas limit #1775

Merged
merged 3 commits into from
Sep 3, 2020
Merged

Fix MMM not respecting Wallet Connect gas limit #1775

merged 3 commits into from
Sep 3, 2020

Conversation

EtDu
Copy link
Contributor

@EtDu EtDu commented Aug 17, 2020

Description
Fixes MMM not using the gas limit supplied by wallet connect for eth_sendTransaction and defaulting to 31500

Issue

Resolves #1520

@EtDu EtDu requested a review from a team as a code owner August 17, 2020 03:35
rickycodes
rickycodes approved these changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@rickycodes rickycodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@EtDu EtDu added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Aug 19, 2020
ibrahimtaveras00
ibrahimtaveras00 approved these changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Passed 👍

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Sep 2, 2020
@EtDu EtDu merged commit 8870927 into develop Sep 3, 2020
@EtDu EtDu deleted the walletconnect-gas branch September 3, 2020 03:43
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@EtDu
WalletConnect: fix WC not respecting gas limit (#1775)
cd6253f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

@rickycodes rickycodes rickycodes approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gas limit from wallet connect not respected
3 participants
@EtDu @rickycodes @ibrahimtaveras00