Improvement/browser refactor #1829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibrahimtaveras00
added
needs-qa
ibrahimtaveras00
removed
the
needs-qa
ibrahimtaveras00
added
needs-dev-review
rickycodes
force-pushed
the
improvement/browser-refactor
branch
from
09df6c7 to
c17a6f0
Compare
rickycodes
approved these changes
Sep 21, 2020
estebanmino
reviewed
Sep 28, 2020
| /** | ||
| * Add bookmark | ||
| */ | ||
| const addBookmark = () => { |
There was a problem hiding this comment.
this could be missing the bookmarks passes in the script
There was a problem hiding this comment.
disregard this comment
estebanmino
reviewed
Sep 28, 2020
| @@ -487,25 +407,17 @@ export class BrowserTab extends PureComponent { | |||
| const rpcMethods = { | |||
| eth_requestAccounts: async () => { | |||
There was a problem hiding this comment.
this method is not working when calling it directly. for ex uniswap.eth
estebanmino
reviewed
Sep 28, 2020
| {!isHidden() && renderWatchAssetModal()} | ||
| {!isHidden() && renderOptions()} | ||
| {!isHidden() && renderBottomBar()} | ||
| {!isHidden() && renderOnboardingWizard()} |
There was a problem hiding this comment.
feels like we're calling this method too many times on render?
estebanmino
reviewed
Sep 28, 2020
| {!isHidden() && renderPhishingModal()} | ||
| {!isHidden() && renderUrlModal()} | ||
| {!isHidden() && renderApprovalModal()} | ||
| {!isHidden() && renderPhishingModal()} |
There was a problem hiding this comment.
two calls of renderPhishingModal
rickycodes
added a commit
that referenced
this pull request
Jan 31, 2022
* First implementation working * finish use effect * Update webview * Fix watch asset * Improve url modal * Fix replace and remove unused variable * Comments * Fix approved hosts & webview inject * Fix effects and callbacks * Update test and remove unecessary comments * Fix redirections * Fix more redirects * Fix redirections and add icon * Fix address bar icon * Move some variables from state to component and native webview fix * remove logs * Update tabs and fix patch package error * Improve tabs initial performance * Fix www replace * move render phishing up * update test * fixing phishing with timeout * Update test * Tidy up getFavicon * ishidden * snap Co-authored-by: rickycodes <ricky.miller@gmail.com> Co-authored-by: Esteban Mino <efmino@uc.cl>
cryptodev-2s
added a commit
that referenced
this pull request
Jul 24, 2024
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** - Update the attribution link to match the current app version. - The update-attributions workflow was using a low-privilege token for checking out the repository. The checkout step is what determines which credentials are used upon push. The later step with git push well fail with a HTTP 403 response despite having a token declared with write access, because git push uses the credentials setup during checkout. <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Related issues** Fixes: [#1829](MetaMask/mobile-planning#1829) ## **Manual testing steps** 1. Go to`Settings` Page. 2. Scroll down and click on `About Metamask`. 3. Click on `Attributions`. 4. You should then be redirected to https://raw.githubusercontent.com/MetaMask/metamask-mobile/v7.27.0/attribution.txt (where v7.27.0 is the current Metamask Mobile version) ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** https://github.com/user-attachments/assets/99acf283-a3df-4332-b8f9-85b622f1a838 <!-- [screenshots/recordings] --> ### **After** https://github.com/user-attachments/assets/7db6972e-96c7-4689-8c1b-2802704bb886 <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Browser refactoring and update of the native webview.
Checklist