Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI/CustomGas: fix inconsistent low gas error #1835

Merged
merged 3 commits into from
Sep 22, 2020
Merged

UI/CustomGas: fix inconsistent low gas error #1835

merged 3 commits into from
Sep 22, 2020

Conversation

EtDu
Copy link
Contributor

@EtDu EtDu commented Sep 16, 2020

Fixes "gas price extremely low" error message showing up inconsistently.

Resolves #1833

@EtDu EtDu requested a review from a team as a code owner September 16, 2020 06:59
@EtDu EtDu added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Sep 17, 2020
ibrahimtaveras00
ibrahimtaveras00 approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue is fixed, QA Passed 👍

There were some other issues I noticed, where I couldn't tap save on android, and that no error shows up whatsoever on wallet send flow, but I'm assuming those two issues will be fixed in these issues :

Gas Issue One
Gas Issue Two

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Sep 21, 2020
@EtDu
Copy link
Contributor Author

EtDu commented Sep 22, 2020

@ibrahimtaveras00 Yes, I have that one captured. #1834

@EtDu EtDu merged commit afd35ea into develop Sep 22, 2020
@EtDu EtDu deleted the buggy-low-gas-error branch September 22, 2020 04:35
omnat
omnat reviewed Sep 28, 2020
View reviewed changes
Copy link
Contributor

@omnat omnat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://trello.com/c/oRRxpJsW/231-make-insufficient-fee-error-descriptive-add-link-to-buy-eth
@EtDu is this the copy you updated here?

@EtDu
Copy link
Contributor Author

EtDu commented Sep 29, 2020

@omnat No, this is a different issue. I haven't gotten to that one yet.

rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@EtDu
UI/CustomGas: fix inconsistent low gas error (#1835)
c3a4d1e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omnat omnat omnat left review comments

@rickycodes rickycodes rickycodes approved these changes

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gas too low error message inconsistent
4 participants
@EtDu @rickycodes @ibrahimtaveras00 @omnat