Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get e2e working for seedphrase and login #1861

Merged
merged 3 commits into from
Oct 2, 2020

Conversation

rickycodes
Copy link
Member

Description

I broke e2e tests when I updated seedphrase import and login screens. this gets them working again :)

sorry @ibrahimtaveras00 !

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

@rickycodes rickycodes requested a review from a team as a code owner September 30, 2020 04:59
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀
Looks good on both OS's, QA Passed 👍

Screen Shot 2020-09-30 at 2 15 02 PM

@ibrahimtaveras00 ibrahimtaveras00 added the QA Passed A successful QA run through has been done label Sep 30, 2020
@rickycodes rickycodes force-pushed the bugfix/detox-seedphrase-updates branch from b3a2113 to 3023048 Compare September 30, 2020 20:57
@rickycodes rickycodes force-pushed the bugfix/detox-seedphrase-updates branch from 3023048 to e92a7ea Compare October 2, 2020 17:01
@rickycodes rickycodes merged commit 78f9150 into develop Oct 2, 2020
@rickycodes rickycodes deleted the bugfix/detox-seedphrase-updates branch October 2, 2020 17:17
rickycodes added a commit that referenced this pull request Jan 31, 2022
* Get e2e working for seedphrase and login

* use i18n strings

* remove condition on iOS

Co-authored-by: Ibrahim Taveras <ibrahimtaveras@Ibrahims-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA Passed A successful QA run through has been done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants