Provide error feedback without actually submitting #1873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickycodes
force-pushed
the
bugfix/provide-error-feedback-on-login
branch
from
d74effa
to
3653042
Compare
rickycodes
added
the
needs-dev-review
estebanmino
reviewed
Oct 6, 2020
app/components/Views/Login/index.js
Outdated
| @@ -332,7 +334,7 @@ class Login extends PureComponent { | |||
|
|
|||
| render = () => { | |||
| const { password } = this.state; | |||
| const disabled = !passwordRequirementsMet(password); | |||
| const locked = !passwordRequirementsMet(password); | |||
There was a problem hiding this comment.
shouldn't we have this on onLogin? feels like we're doing calculations on render that could be moved to do it just once
There was a problem hiding this comment.
actually that's a good point, now that we're not doing anything in the render (disabling the button), we could just move it to onLogin
estebanmino
approved these changes
Oct 6, 2020
rickycodes
added
the
needs-qa
ibrahimtaveras00
added
QA Passed
My earlier idea of keeping the login button locked is just going to be confusing to users. We should provide feedback and keep the button enabled. But! We're still not attempting to Unlock for real, which I think is ultimately what we want here.
rickycodes
force-pushed
the
bugfix/provide-error-feedback-on-login
branch
from
8f0a08c
to
5f17dcb
Compare
rickycodes
added a commit
that referenced
this pull request
Jan 31, 2022
My earlier idea of keeping the login button locked is just going to be confusing to users. We should provide feedback and keep the button enabled. But! We're still not attempting to Unlock for real, which I think is ultimately what we want here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My earlier idea of keeping the login button disabled is just going to be confusing to users (I find it confusing myself now that I've been using it). We should provide feedback and keep the button enabled. But! We're still not attempting to Unlock for real (until requirements are met), which I think is ultimately what we want here.
Checklist
Issue
Resolves #???