Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error boundary #1882

Merged
merged 8 commits into from
Oct 13, 2020
Merged

Error boundary #1882

merged 8 commits into from
Oct 13, 2020

Conversation

andrepimenta
Copy link
Member

@andrepimenta andrepimenta commented Oct 8, 2020 •
edited
Loading

Description

Error boundary for catching errors, logging them to sentry and showing a nice error screen to the user.

@andrepimenta andrepimenta requested a review from a team as a code owner October 8, 2020 14:59
@andrepimenta andrepimenta changed the title error boundary init Error boundary Oct 8, 2020
@andrepimenta andrepimenta marked this pull request as draft October 8, 2020 15:37
@omnat omnat added this to the v1.0.4 milestone Oct 8, 2020
@andrepimenta andrepimenta marked this pull request as ready for review October 9, 2020 14:37
@andrepimenta andrepimenta added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Oct 9, 2020
estebanmino
estebanmino approved these changes Oct 9, 2020
View reviewed changes
Copy link
Contributor

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

app/components/Views/ErrorBoundary/index.js Outdated

copyErrorToClipboard = async () => {
await Clipboard.setString(this.getErrorMessage());
Alert.alert('Copied to clipboard', '', [{ text: 'OK' }], {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small thing here, can we move it to strings?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes thanks!

ibrahimtaveras00
ibrahimtaveras00 approved these changes Oct 9, 2020
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Passed 👍

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Oct 9, 2020
@andrepimenta andrepimenta merged commit 799a1e4 into develop Oct 13, 2020
@andrepimenta andrepimenta deleted the feature/error-boundary branch October 13, 2020 17:12
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@andrepimenta
Error boundary (#1882)
8599838 
* error boundary init

* Create our error screen

* Move error boundary screen to views and remove unecessary library

* Put the error boundary on more views

* remove console log

* Add alert to strings

* update design
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estebanmino estebanmino estebanmino approved these changes

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

Assignees
No one assigned
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) next release QA Passed A successful QA run through has been done
Projects
None yet
Milestone
v1.0.4
Development

Successfully merging this pull request may close these issues.
4 participants
@andrepimenta @estebanmino @ibrahimtaveras00 @omnat