Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make hintText display regardless of biometryType #1978

Merged
merged 1 commit into from
Nov 11, 2020
Merged

Make hintText display regardless of biometryType #1978

merged 1 commit into from
Nov 11, 2020

Conversation

rickycodes
Copy link
Contributor

Description

@ibrahimtaveras00 discovered a bug,

tuns out the hintText was only being set in state if the biometryType was set

whoops.

this fixes that.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

@rickycodes rickycodes requested a review from a team as a code owner November 11, 2020 00:35
@rickycodes rickycodes added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Nov 11, 2020
estebanmino
estebanmino approved these changes Nov 11, 2020
View reviewed changes
Copy link
Contributor

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one small comment

@rickycodes rickycodes force-pushed the bugfix/fix-hintText-display branch from 2087372 to 94c3849 Compare November 11, 2020 17:58
@rickycodes rickycodes removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 11, 2020
ibrahimtaveras00
ibrahimtaveras00 approved these changes Nov 11, 2020
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Passed 👍

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Nov 11, 2020
@rickycodes rickycodes merged commit 4feb74e into develop Nov 11, 2020
@rickycodes rickycodes deleted the bugfix/fix-hintText-display branch November 11, 2020 19:03
rickycodes added a commit that referenced this pull request Jan 31, 2022
@rickycodes
Make hintText display regardless of biometryType (#1978)
e76b531
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

@estebanmino estebanmino estebanmino approved these changes

Assignees
No one assigned
Labels
next release QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rickycodes @estebanmino @ibrahimtaveras00