Fix whats new modal #1983
Merged
Fix whats new modal #1983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estebanmino
reviewed
Nov 11, 2020
| @@ -407,7 +408,7 @@ class DrawerView extends PureComponent { | |||
| componentDidUpdate() { | |||
| const route = this.findRouteNameFromNavigatorState(this.props.navigation.state); | |||
| if (!this.props.passwordSet || !this.props.seedphraseBackedUp) { | |||
| if (['SetPasswordFlow', 'Webview'].includes(route)) { | |||
| if (['SetPasswordFlow', 'Webview', 'ChoosePassword'].includes(route)) { | |||
There was a problem hiding this comment.
if you move away from ChoosePassword view, isn't the modal appearing again?
estebanmino
reviewed
Nov 11, 2020
| @@ -1045,6 +1055,11 @@ class DrawerView extends PureComponent { | |||
| showReceiveModal={this.showReceiveModal} | |||
| /> | |||
| </Modal> | |||
| <WhatsNewModal | |||
| navigation={this.props.navigation} | |||
| enabled={this.state.showProtectWalletModal === false} | |||
There was a problem hiding this comment.
was this on purpose? enabled if false
also why not !this.state.showProtectWalletModal?
There was a problem hiding this comment.
This was more or less a little hack that I had to do in order for the modals not to overlap one another, for some reason it was happening, I think it's because the native side was being faster then the render I am not sure.
So for this to work this.state.showProtectWalletModal starts with undefined. Then we update it either to true or false. Only when it's false it shows the whats new modal.
estebanmino
approved these changes
Nov 11, 2020
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* Working * update tests * Fix show whats new modal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes whats new modal
Checklist
Issue
Resolves #???