Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix asyncstorage limit #2034

Merged
merged 6 commits into from
Dec 2, 2020
Merged

Fix asyncstorage limit #2034

merged 6 commits into from
Dec 2, 2020

Conversation

rickycodes
Copy link
Member

@rickycodes rickycodes commented Dec 2, 2020

Description

Fix asyncstorage limit

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #2011

@rickycodes rickycodes changed the title fix asyncstorage limit Fix asyncstorage limit Dec 2, 2020
@estebanmino estebanmino mentioned this pull request Dec 2, 2020
3 tasks
@rickycodes rickycodes force-pushed the bugfix/asyncstorage-limit branch 2 times, most recently from 52884e1 to 9b53a3b Compare December 2, 2020 21:14
@rickycodes rickycodes marked this pull request as ready for review December 2, 2020 21:14
@rickycodes rickycodes requested a review from a team as a code owner December 2, 2020 21:14
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Passed 👍

@ibrahimtaveras00 ibrahimtaveras00 merged commit bf23c74 into develop Dec 2, 2020
@ibrahimtaveras00 ibrahimtaveras00 deleted the bugfix/asyncstorage-limit branch December 2, 2020 22:03
@mjgardner33
Copy link

Hi, I never use github. Can I use this to fix the bug yet? Sorry if it's a dumb question lol

rickycodes added a commit that referenced this pull request Jan 31, 2022
* fix asyncstorage limit

* add version check

* Update error message

* remove version check

* toLowerCase not toLocaleLowerCase

* loading: false
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Error: cannot unlock without a previous vault" upon entering password
4 participants