Display boolean values when signing typed data #2142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickycodes
approved these changes
Jan 20, 2021
|
It looks like CI isn't running for this PR (probably because I'm not a collaborator). |
|
@nlordell thanks for the contribution! I've taken the liberty of enabling CI jobs for third party contributors (forks). I've also pushed up a couple changes to your PR to get that working (I hope you don't mind). |
|
Of course not! Thanks for the help! |
rickycodes
added a commit
that referenced
this pull request
Jan 31, 2022
* Display boolean values when signing typed data * Provide fallback for MM_INFURA_PROJECT_ID Co-authored-by: ricky <ricky.miller@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR applies the same fix as the browser extension (MetaMask/metamask-extension#4639)
The issue is that boolean values have special meaning in JSX and do not render their string representation. The solution is to simply
toStringthe values to be displayed. Note that${...}toStringdirectly to avoid any error from null or undefined values.Unfortunately, I was not able to build the MetaMask mobile app to verify my change works. I followed the steps for building on Android but ran into a few issues that I couldn't get past (specifically, I get an error building
react-native-aes-crypto:error: method pbkdf2Sync(String,String,Integer,Integer) is already defined in class RCTAes).That being said, I was able to test my assumption that rendering
booleans is an issue using the playground on the React Native dev site.Issue
Resolves #2141